Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slice out of bounds error in mailer #2479

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Fix slice out of bounds error in mailer #2479

merged 1 commit into from
Sep 11, 2017

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented Sep 10, 2017

Fix #2472 by using TruncateString() instead of just slicing and hoping for the best.

@lunny lunny added the type/bug label Sep 10, 2017
@lunny lunny added this to the 1.3.0 milestone Sep 10, 2017
@lafriks
Copy link
Member

lafriks commented Sep 10, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 10, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 10, 2017
@lunny
Copy link
Member

lunny commented Sep 11, 2017

@cez81 please rebase

@cez81
Copy link
Contributor Author

cez81 commented Sep 11, 2017

@lunny Rebase done

@lunny lunny merged commit 01d7189 into go-gitea:master Sep 11, 2017
@cez81 cez81 deleted the issue2472 branch September 11, 2017 06:40
@ptman ptman mentioned this pull request Oct 12, 2017
Closed
2 tasks
lunny pushed a commit to lunny/gitea that referenced this pull request Oct 13, 2017
@cez81 @lunny
Fix slice out of bounds error in mailer (go-gitea#2479)
678dcc3
@lunny lunny mentioned this pull request Oct 13, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 13, 2017
lafriks pushed a commit that referenced this pull request Oct 13, 2017
@lunny @lafriks
Fix slice out of bounds error in mailer (#2479) (#2696)
670562a
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Testmail produces 500 Internal Server Error
6 participants
@cez81 @lafriks @ethantkoenig @lunny @tboerger @bkcsoft